Allow the selection between CMD and Powershell and prefer CMD for dataInjections #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Racer159
requested review from
mike-winberry,
Noxsios,
jeff-mccoy,
YrrepNoj,
Madeline-UX,
JasonvanBrackel,
wirewc and
a team
as code owners
✅ Deploy Preview for zarf-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
YrrepNoj
reviewed
Apr 10, 2023
Noxsios
reviewed
Apr 14, 2023
|
It is integrated with defaults. |
YrrepNoj
previously approved these changes
Apr 14, 2023
YrrepNoj
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows package creators to select between cmd and powershell for actions and prefers cmd over powershell for dataInjections.
Related Issue
Fixes #N/A
More info: https://kubernetes.slack.com/archives/C03B6BJAUJ3/p1680880810057189?thread_ts=1680097325.822069&cid=C03B6BJAUJ3
Type of change
Checklist before merging